Typo in docs

mzimmers

Hi all -

Not sure if this is the right place to mention this, but on this page there appears to be a typo. The line (in an example fragment) that reads:

qt_standard_project_setup(REQUIRED 6.5)

should be (I believe):

qt_standard_project_setup(REQUIRES 6.5)

Yes?

JoeCFD

@mzimmers I guess you are right.
https://doc.qt.io/qt-6/qt-standard-project-setup.html

SGaist

Hi @mzimmers,

Looks like you found something ! Would you consider making a patch to fix it ? :-)

mzimmers

@SGaist I tried to push my fix, and got this message:

$ git push gerrit HEAD:refs/for/fix_typo
fatal: No Contributor Agreement on file for user Michael Zimmers <mzimmers@gmail.com> (id=1011489)https://codereview.qt-project.org/settings#Agreements
fatal: Could not read from remote repository.

I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

JKSH

@mzimmers said in Typo in docs:

I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

Step #4 from https://wiki.qt.io/Setting_up_Gerrit#How_to_get_started_-_Gerrit_registration

SGaist

@mzimmers beside the recommendation of @JKSH:
it'sgit push gerrit HEAD:refs/for/dev from within your branch

mzimmers

Aargh - somewhere along the way, I got my corporate email mixed in with my personal email, and now my push gets this error:

remote: ERROR: commit 1d4a075: email address mzimmers@fluidra.com is not registered in your account, and you lack 'forge committer' permission.

I'd prefer to use my personal email. I already changed my address in my .gitconfig file (and started a new shell session), but it's still trying to use my corporate email. Any quick fix for this?

Thanks...

EDIT:

I went ahead and added my corporate email address to my account. Now, I get a new error, but I think I can fix this. I'll report back.

EDIT 2:

I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

Thanks.

JKSH

@mzimmers said in Typo in docs:

I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

Congrats, I can see your patch: https://codereview.qt-project.org/c/qt/qtdoc/+/471173 Normally, you would now add a Reviewer who can check and approve your patch.

Alas, someone else already beat you to it in this case: https://codereview.qt-project.org/c/qt/qtdoc/+/471064

But you are now set up for future patches :)

Aargh - somewhere along the way, I got my corporate email mixed in with my personal email

You need to change your Git settings: https://stackoverflow.com/questions/37805621/change-email-address-in-git

mzimmers

@JKSH said in Typo in docs:

Alas, someone else already beat you to it

Not surprising, considering how much time lapsed before I got it pushed.

Thanks for the help on this stuff...we'll see how much faster I am the next time...