Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Behind the Scenes
  3. Qt.io webservices
  4. Typo in docs
Forum Updated to NodeBB v4.3 + New Features

Typo in docs

Scheduled Pinned Locked Moved Solved Qt.io webservices
9 Posts 4 Posters 833 Views 3 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • mzimmersM Offline
    mzimmersM Offline
    mzimmers
    wrote on last edited by
    #1

    Hi all -

    Not sure if this is the right place to mention this, but on this page there appears to be a typo. The line (in an example fragment) that reads:

    qt_standard_project_setup(REQUIRED 6.5)
    

    should be (I believe):

    qt_standard_project_setup(REQUIRES 6.5)
    

    Yes?

    JoeCFDJ SGaistS 2 Replies Last reply
    0
    • mzimmersM mzimmers

      Hi all -

      Not sure if this is the right place to mention this, but on this page there appears to be a typo. The line (in an example fragment) that reads:

      qt_standard_project_setup(REQUIRED 6.5)
      

      should be (I believe):

      qt_standard_project_setup(REQUIRES 6.5)
      

      Yes?

      JoeCFDJ Offline
      JoeCFDJ Offline
      JoeCFD
      wrote on last edited by JoeCFD
      #2

      @mzimmers I guess you are right.
      https://doc.qt.io/qt-6/qt-standard-project-setup.html

      1 Reply Last reply
      0
      • mzimmersM mzimmers

        Hi all -

        Not sure if this is the right place to mention this, but on this page there appears to be a typo. The line (in an example fragment) that reads:

        qt_standard_project_setup(REQUIRED 6.5)
        

        should be (I believe):

        qt_standard_project_setup(REQUIRES 6.5)
        

        Yes?

        SGaistS Offline
        SGaistS Offline
        SGaist
        Lifetime Qt Champion
        wrote on last edited by
        #3

        Hi @mzimmers,

        Looks like you found something ! Would you consider making a patch to fix it ? :-)

        Interested in AI ? www.idiap.ch
        Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

        mzimmersM 1 Reply Last reply
        0
        • SGaistS SGaist

          Hi @mzimmers,

          Looks like you found something ! Would you consider making a patch to fix it ? :-)

          mzimmersM Offline
          mzimmersM Offline
          mzimmers
          wrote on last edited by
          #4

          @SGaist I tried to push my fix, and got this message:

          $ git push gerrit HEAD:refs/for/fix_typo
          fatal: No Contributor Agreement on file for user Michael Zimmers <mzimmers@gmail.com> (id=1011489)https://codereview.qt-project.org/settings#Agreements
          fatal: Could not read from remote repository.
          

          I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

          JKSHJ SGaistS 2 Replies Last reply
          0
          • mzimmersM mzimmers

            @SGaist I tried to push my fix, and got this message:

            $ git push gerrit HEAD:refs/for/fix_typo
            fatal: No Contributor Agreement on file for user Michael Zimmers <mzimmers@gmail.com> (id=1011489)https://codereview.qt-project.org/settings#Agreements
            fatal: Could not read from remote repository.
            

            I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

            JKSHJ Offline
            JKSHJ Offline
            JKSH
            Moderators
            wrote on last edited by
            #5

            @mzimmers said in Typo in docs:

            I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

            Step #4 from https://wiki.qt.io/Setting_up_Gerrit#How_to_get_started_-_Gerrit_registration

            Qt Doc Search for browsers: forum.qt.io/topic/35616/web-browser-extension-for-improved-doc-searches

            1 Reply Last reply
            1
            • mzimmersM mzimmers

              @SGaist I tried to push my fix, and got this message:

              $ git push gerrit HEAD:refs/for/fix_typo
              fatal: No Contributor Agreement on file for user Michael Zimmers <mzimmers@gmail.com> (id=1011489)https://codereview.qt-project.org/settings#Agreements
              fatal: Could not read from remote repository.
              

              I thought I'd followed all the setup steps for gerrit...can you tell from this message what I might have missed?

              SGaistS Offline
              SGaistS Offline
              SGaist
              Lifetime Qt Champion
              wrote on last edited by
              #6

              @mzimmers beside the recommendation of @JKSH:
              it'sgit push gerrit HEAD:refs/for/dev from within your branch

              Interested in AI ? www.idiap.ch
              Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

              mzimmersM 1 Reply Last reply
              2
              • SGaistS SGaist

                @mzimmers beside the recommendation of @JKSH:
                it'sgit push gerrit HEAD:refs/for/dev from within your branch

                mzimmersM Offline
                mzimmersM Offline
                mzimmers
                wrote on last edited by mzimmers
                #7

                Aargh - somewhere along the way, I got my corporate email mixed in with my personal email, and now my push gets this error:

                remote: ERROR: commit 1d4a075: email address mzimmers@fluidra.com is not registered in your account, and you lack 'forge committer' permission.
                

                I'd prefer to use my personal email. I already changed my address in my .gitconfig file (and started a new shell session), but it's still trying to use my corporate email. Any quick fix for this?

                Thanks...

                EDIT:

                I went ahead and added my corporate email address to my account. Now, I get a new error, but I think I can fix this. I'll report back.

                EDIT 2:

                I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

                Thanks.

                JKSHJ 1 Reply Last reply
                0
                • mzimmersM mzimmers

                  Aargh - somewhere along the way, I got my corporate email mixed in with my personal email, and now my push gets this error:

                  remote: ERROR: commit 1d4a075: email address mzimmers@fluidra.com is not registered in your account, and you lack 'forge committer' permission.
                  

                  I'd prefer to use my personal email. I already changed my address in my .gitconfig file (and started a new shell session), but it's still trying to use my corporate email. Any quick fix for this?

                  Thanks...

                  EDIT:

                  I went ahead and added my corporate email address to my account. Now, I get a new error, but I think I can fix this. I'll report back.

                  EDIT 2:

                  I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

                  Thanks.

                  JKSHJ Offline
                  JKSHJ Offline
                  JKSH
                  Moderators
                  wrote on last edited by
                  #8

                  @mzimmers said in Typo in docs:

                  I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

                  Congrats, I can see your patch: https://codereview.qt-project.org/c/qt/qtdoc/+/471173 Normally, you would now add a Reviewer who can check and approve your patch.

                  Alas, someone else already beat you to it in this case: https://codereview.qt-project.org/c/qt/qtdoc/+/471064

                  But you are now set up for future patches :)

                  Aargh - somewhere along the way, I got my corporate email mixed in with my personal email

                  You need to change your Git settings: https://stackoverflow.com/questions/37805621/change-email-address-in-git

                  Qt Doc Search for browsers: forum.qt.io/topic/35616/web-browser-extension-for-improved-doc-searches

                  mzimmersM 1 Reply Last reply
                  0
                  • JKSHJ JKSH

                    @mzimmers said in Typo in docs:

                    I think I got it...can someone check to see if it went through OK, and if I need to do anything else (I think I remember reading something about notifying the group)?

                    Congrats, I can see your patch: https://codereview.qt-project.org/c/qt/qtdoc/+/471173 Normally, you would now add a Reviewer who can check and approve your patch.

                    Alas, someone else already beat you to it in this case: https://codereview.qt-project.org/c/qt/qtdoc/+/471064

                    But you are now set up for future patches :)

                    Aargh - somewhere along the way, I got my corporate email mixed in with my personal email

                    You need to change your Git settings: https://stackoverflow.com/questions/37805621/change-email-address-in-git

                    mzimmersM Offline
                    mzimmersM Offline
                    mzimmers
                    wrote on last edited by
                    #9

                    @JKSH said in Typo in docs:

                    Alas, someone else already beat you to it

                    Not surprising, considering how much time lapsed before I got it pushed.

                    Thanks for the help on this stuff...we'll see how much faster I am the next time...

                    1 Reply Last reply
                    1
                    • mzimmersM mzimmers has marked this topic as solved on

                    • Login

                    • Login or register to search.
                    • First post
                      Last post
                    0
                    • Categories
                    • Recent
                    • Tags
                    • Popular
                    • Users
                    • Groups
                    • Search
                    • Get Qt Extensions
                    • Unsolved