Merge two pieces of code

[SGaist]

About what ?

[john_hobbyist]

@SGaist

Both on

MyMplCanvas(mpl_qt.FigureCanvasQTAgg)

and

OrthoView(QMainWindow) 

the methods do not run.
So where else should I put the methods?

"QMainWindow does indeed not have a set_canvas method." ---> What should I do in this case? I am based on ready code, I cannot build a set_canvas method

Thanks!

[SGaist]

Please show the exact code you have currently.

[john_hobbyist]

@SGaist

# -*- coding: utf-8 -*-
"""
OrthoViewLite.py
based on https://github.com/kklmn/OrthoView by Konstantin Klementiev
modified by Axel Schneider (added File Selector)
https://github.com/Axel-Erfurt
"""

__author__ = "Konstantin Klementiev"
__versioninfo__ = (1, 0, 2)
__version__ = '.'.join(map(str, __versioninfo__))
__date__ = "8 Feb 2020"
__license__ = "MIT license"

import os
print("1")
import sys
print("2")
import cv2
print("3")
from matplotlib.figure import Figure
print("4")
import numpy as np
print("5")
from PyQt5.QtGui import QIcon
print("6")
from PyQt5.QtWidgets import (QMainWindow, QApplication, QWidget,QAction, QFileDialog, QMenu, 
                             QToolBar, QHBoxLayout, QTreeView, QFileSystemModel, QSizePolicy, 
                             QMessageBox)
print("7")
from PyQt5.QtCore import Qt, QDir, QStandardPaths, QFileInfo
print("8")
import matplotlib.backends.backend_qt5agg as mpl_qt
print("9")

#########################################################################
import rubberband
import sys
"""
from PySide2.QtCore import QRect
from PySide2.QtCore import QSize
from PySide2.QtWidgets import QWidget
from PySide2.QtWidgets import QRubberBand
from PySide2.QtWidgets import QApplication
import PySide2
"""

from PyQt5 import QtWidgets
from PyQt5 import QtCore 


from PyQt5.QtWidgets import * 
from PyQt5 import QtCore, QtGui
from PyQt5.QtGui import * 
from PyQt5.QtCore import * 
###########################################################################

try:
    from ConfigParser import ConfigParser
except ImportError:
    from configparser import ConfigParser

print("10")
selfDir = os.path.dirname(__file__)
print("11")
iniApp = (os.path.join(selfDir, 'OrthoViewList.ini'))
print("12")
config = ConfigParser(
    dict(pos='[0, 0]', corners='[None]*4', scalex=0, scaley=0))
print("13")
config.add_section('window')
print("14")
config.read(iniApp)
print("15")

def write_config():
    print("16")
    with open(iniApp, 'w+') as cf:
        print("17")
        config.write(cf)
        print("18")


class MyToolBar(mpl_qt.NavigationToolbar2QT):
    def set_message(self, s):
        print("19")
        try:
            print("20")
            sstr = s.split()
            print("21")
            while len(sstr) > 5:
                print("22")
                del sstr[0]
                print("23")
            x, y = float(sstr[0][2:]), float(sstr[1][2:])
            print("24")
            s = f'x = {x:.2f}\ny = {y:.2f}'
            print("25")
        except Exception:
            print("26")
            pass
        print("27")

        if self.coordinates:
            print("28")
            self.locLabel.setText(s)
            print("29")


class MyMplCanvas(mpl_qt.FigureCanvasQTAgg):
    def __init__(self, parent=None):
        print("30")
        self.fig = Figure()
        print("31")
        self.fig.patch.set_facecolor('None')
        print("32")
        super(MyMplCanvas, self).__init__(self.fig)
        print("33")
        self.setParent(parent)
        print("34")
        self.updateGeometry()
        print("35")
        self.setupPlot()
        print("36")
        self.mpl_connect('button_press_event', self.onPress)
        print("37")
        self.img = None
        print("38")
        self.setContextMenuPolicy(Qt.CustomContextMenu)
        print("39")
        self.mouseClickPos = None
        print("40")
        self.menu = QMenu()
        print("41")


    def setupPlot(self):
        print("42")
        rect = [0., 0., 1., 1.]
        print("43")
        self.axes = self.fig.add_axes(rect)
        print("44")
        self.axes.axis("off")
        print("45")

    def imshow(self, img):
        print("46")
        if self.img is None:
            print("47")
            self.img = self.axes.imshow(img)
            print("48")
        else:
            print("49")
            prev = self.img.get_array()
            print("50")
            self.img.set_data(img)
            print("51")
            if prev.shape != img.shape:
                print("52")
                self.img.set_extent(
                    [-0.5, img.shape[1]-0.5, img.shape[0]-0.5, -0.5])
                print("53")
                self.axes.set_xlim((0, img.shape[1]))
                print("54")
                self.axes.set_ylim((img.shape[0], 0))
                print("55")
                self.toolbar.update()
                print("56")
        self.draw()
        print("57")

    def onPress(self, event):
        print("58")
        if (event.xdata is None) or (event.ydata is None):
            print("59")
            self.mouseClickPos = None
            print("60")
            return
        print("61")
        self.mouseClickPos = int(round(event.xdata)), int(round(event.ydata))
        print("62")


class OrthoView(QMainWindow):
    def __init__(self, parent=None):
        
        ####################################
        super().__init__(parent)

        self.rubberBand = None
        self.origin = None
        ####################################

        print("63")
        super(OrthoView, self).__init__(parent)
        print("64")
        self.setWindowTitle('OrthoViewLite')
        print("65")
        self.setStyleSheet("QMainWindow {background: #e9e9e9;} QHBoxLayout \
                            {background: #e9e9e9;} QTreeView {background: #e9e9e9;}  \
                            FigureCanvasQTAgg {background: #e9e9e9;} QToolBar {border: 0px;}")
        print("66")
        self.setMinimumSize(500, 350)
        print("67")
        self.image_file_path = ""   
        print("68")
        if config.has_option('window', 'win_left') and config.has_option('window', 'win_top') \
            and config.has_option('window', 'win_width') and config.has_option('window', 'win_height'):
            left = int(config.get('window', 'win_left'))
            top = int(config.get('window', 'win_top'))
            width = int(config.get('window', 'win_width'))
            height = int(config.get('window', 'win_height'))
            print("69")
            self.setGeometry (left, top, width, height)
            print("70")
        print("71")
        self.home_path = QStandardPaths.standardLocations(QStandardPaths.PicturesLocation)[0]
        print("72")
        self.tb = QToolBar("File")
        print("73")
        empty = QWidget()
        print("74")
        empty.setSizePolicy(QSizePolicy.Expanding, QSizePolicy.Expanding)
        print("75")
        self.tb.addWidget(empty)
        print("76")
        open_btn = QAction("Open Image File", self, triggered=self.openFile)
        print("77")
        open_btn.setIcon(QIcon.fromTheme("document-open"))
        print("78")
        self.tb.addAction(open_btn)
        print("79")
        go_up_btn = QAction("one level up", self, triggered=self.oneUp)
        print("80")
        go_up_btn.setIcon(QIcon.fromTheme("go-up"))
        print("81")
        self.tb.addAction(go_up_btn)
        print("82")
        go_home_btn = QAction("go to home", self, triggered=self.goHome)
        print("83")
        go_home_btn.setIcon(QIcon.fromTheme("go-home"))
        print("84")
        self.tb.addAction(go_home_btn)
        print("85")
        stretch = QWidget()
        print("86")
        stretch.setFixedWidth(200)
        print("87")
        self.tb.addWidget(stretch)
        print("88")

        self.plotCanvas = MyMplCanvas(self)
        print("89")
        self.plotCanvas.setSizePolicy(
            QSizePolicy.Expanding, QSizePolicy.Expanding)
        print("90")
        self.toolbar = MyToolBar(self.plotCanvas, self)
        print("91")
        for action in self.toolbar.findChildren(QAction):
            if action.text() in ['Customize', 'Subplots']:
                action.setVisible(False)
                print("92")
        self.toolbar.locLabel.setAlignment(Qt.AlignRight)
        print("93")
        self.toolbar.locLabel.setFixedWidth(200)
        print("94")
        self.tb.setContextMenuPolicy(Qt.PreventContextMenu)
        print("95")
        self.tb.setMovable(False)
        print("96")
        self.tb.setAllowedAreas(Qt.TopToolBarArea)
        print("97")
        self.toolbar.setContextMenuPolicy(Qt.PreventContextMenu)
        print("98")
        self.toolbar.setMovable(False)
        print("99")
        self.toolbar.setAllowedAreas(Qt.TopToolBarArea)
        print("100")
        self.addToolBar(self.toolbar)
        print("101")
        self.addToolBar(self.tb)
        print("102")
        
        mylayout = QHBoxLayout()
        print("103")
        mylayout.addWidget(self.plotCanvas)
        print("104")
        
        self.mylistwidget = QTreeView()
        print("105")
        self.mylistwidget.setFixedWidth(300)
        print("106")
        mylayout.addWidget(self.mylistwidget)
        print("107")
        
        self.fileModel = QFileSystemModel()
        print("108")
        self.fileModel.setFilter(QDir.NoDotAndDotDot | QDir.Files | QDir.AllDirs)
        print("109")
        self.fileModel.setRootPath(QDir.homePath())
        print("110")
        
        self.mylistwidget.setModel(self.fileModel)
        print("111")
        self.mylistwidget.setRootIndex(self.fileModel.index(self.home_path))
        print("112")
        #self.mylistwidget.setRootIndex(self.fileModel.index("/"))
        print("113")
        self.mylistwidget.selectionModel().selectionChanged.connect(self.on_clicked)
        print("114")
        self.mylistwidget.clicked.connect(self.tree_clicked)
        print("115")
        col = [1, 2, 3, 4]
        print("116")
        for c in col:
            print("117")
            self.mylistwidget.hideColumn(c)
            print("118")
        mywidget = QWidget()
        print("119")
        mywidget.setLayout(mylayout)
        print("120")
        self.setCentralWidget(mywidget)
        print("121")
        self.myfilter = ["tif", "tiff", "png", "jpg"]
        print("122")
        self.treefilter = ["*.tif", "*.tiff", "*.png", "*.jpg"]
        print("123")
        self.fileModel.setNameFilters(self.treefilter)
        print("124")
        self.fileModel.setNameFilterDisables(False)
        print("125")
        self.mylistwidget.setFocus()   
        print("126")
        self.mylistwidget.resizeColumnToContents(1)
        print("127")

    def goHome(self):
        print("128")
        self.mylistwidget.setRootIndex(self.fileModel.index(self.home_path)) 
        print("129")
       
    def oneUp(self):
        print("130")
        self.mylistwidget.setRootIndex(self.mylistwidget.rootIndex().parent()) 
        print("131")

    def on_clicked(self):
        print("132")
        path = self.fileModel.fileInfo(self.mylistwidget.currentIndex()).absoluteFilePath()
        print("133")
        if QDir.exists(QDir(path)):
            print("134")
            print(path, "is folder")
            print("135")
        else:
            print("136")
            if QFileInfo(path).suffix() in self.myfilter:
                print("137")
                if not os.stat(path).st_size == 0:
                    print("138")
                    print(path)
                    print("139")
                    self.image_file_path = path
                    print("140")
                    self.updateFrame()
                    print("141")
                else:
                    print("142")
                    print("file not exists or has size 0")
                    print("143")
                    self.msgbox("File is empty (size 0)") 
                    print("144")
                
    def tree_clicked(self):
        print("145")
        index = self.mylistwidget.currentIndex()
        print("146")
        if not self.mylistwidget.isExpanded(index):
            print("147")
            self.mylistwidget.setExpanded(index, True) 
            print("148")
            self.mylistwidget.resizeColumnToContents(0)
            print("149")
        else:
            print("150")
            self.mylistwidget.setExpanded(index, False) 
            print("151")
            self.mylistwidget.resizeColumnToContents(0)
            print("152")
        
    def openFile(self):
        print("153")
        print("open File Dialog")
        print("154")
        path, _ = QFileDialog.getOpenFileName(self, "Open File", self.image_file_path,"Image Files (*.tif *.tiff *.png *.jpg)")
        print("155")
        if path:
            print("156")
            if os.path.isfile(path) and not os.stat(path).st_size == 0:
                print("157")
                self.image_file_path = path
                print("158")
                print("file exists:",self.image_file_path)
                print("159")
                self.updateFrame()
                print("160")
            else:
                print("161")
                print("file not exists or has size 0")      
                print("162")
                self.msgbox("File is empty (size 0)")    
                print("163")


    def getFrame(self, path):
        print("170")
        if os.path.isfile(path):
            print("171")
            frame = cv2.imread(path, 1)
            print("172")
            if not np.shape(frame) == ():
                print("173")
                self.img = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
                print("174")
            else:
                print("175")
                print("Error!")
                print("176")
                frame = cv2.imread(path, cv2.IMREAD_UNCHANGED)
                print("177")
                self.img = cv2.cvtColor(frame, cv2.COLOR_BGR2RGB)
                print("178")
        else:
            print("179")
            self.openFile()
            print("180")

    def updateFrame(self):
        print("181")
        self.getFrame(self.image_file_path)
        print("182")
        overlay = self.img.copy()
        print("183")
        alpha = 0.75  # transparency factor
        print("184")
        imageNew = cv2.addWeighted(overlay, alpha, self.img, 1-alpha, 0)
        print("185")
        self.plotCanvas.imshow(imageNew)
        print("186")
        
    def closeEvent(self, e):
        print("187")
        config.set('window', 'win_left', str(self.geometry().x()))
        print("188")
        config.set('window', 'win_top', str(self.geometry().y()))
        print("189")
        config.set('window', 'win_width', str(self.geometry().width()))
        print("190")
        config.set('window', 'win_height', str(self.geometry().height()))
        print("191")
        
        with open(iniApp, 'w+') as cf:
            print("192")
            config.write(cf)
            print("193")

    def msgbox(self, message):
        print("194")
        msg = QMessageBox(2, "Error", message, QMessageBox.Ok)
        print("195")
        msg.exec()
        print("196")
	#++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    def mousePressEvent(self, event):
        print("1000")
        self.origin = event.pos()
        print("1001")
        if not self.rubberBand:
            print("1002")
            self.rubberBand = QRubberBand(QRubberBand.Rectangle, self)
            print("1003")
        self.rubberBand.setGeometry(QRect(self.origin, QSize()))
        print("1004")
        self.rubberBand.show()
        print("1005")

    def mouseMoveEvent(self, event):
        print("1006")
        self.rubberBand.setGeometry(QRect(self.origin, event.pos()).normalized())
        print("1007")

    def mouseReleaseEvent(self, event):
        print("1008")
        self.rubberBand.hide()
        print("1009")
        # determine selection, for example using QRect.intersects()
        # and QRect.contains().
	#++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++


if __name__ == "__main__":
    print("197")
    app = QApplication(sys.argv)
    print("198")
    icon = QIcon(os.path.join(selfDir, '_static', 'orthoview.ico'))
    print("199")
    app.setWindowIcon(icon)
    print("200")

    window = OrthoView()
    print("201")
    window.show()
    print("202")
    #widget = Widget()
    #widget.show()
    sys.exit(app.exec_())

[SGaist]

As already suggested, the mouse handling methods for rubber shall not be in the MainWindow but in your class that shows the image.

[john_hobbyist]

@SGaist So methods inside this method?

def updateFrame(self):

[mrjj]

@john_hobbyist
Hi
Nope, it don't work like that. the mouse function overrides that Qt must call and
they cant be in another function.

under
class MyMplCanvas(mpl_qt.FigureCanvasQTAgg):
def mousePressEvent(self, event):
print("PRESS")

and see if it types "PRESS" if you click on the "image"

If it won't compile it means mpl_qt.FigureCanvasQTAgg is not a QWidget and
its not really possible.

[john_hobbyist]

@mrjj I have just tried it. It prints "PRESS"!

But again if I move the rubberband methods under MyMplCanvas and these:

    super().__init__(parent)

    self.rubberBand = None
    self.origin = None

again the initial error...!!!

[john_hobbyist]

This post is deleted!

[mrjj]

@john_hobbyist

Ok that's good news so it is a QWidget. Then there is hope :)
It reacted to the mousepress!

What error ?

the set_canvas one ?

[john_hobbyist]

@mrjj :-)

Traceback (most recent call last):
  File "code.py", line 653, in <module>
    window = OrthoView()
  File "code.py", line 279, in __init__
    self.plotCanvas = MyMplCanvas(self)
  File "code.py", line 109, in __init__
    super().__init__(parent)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5agg.py", line 21, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5.py", line 214, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 1722, in __init__
    figure.set_canvas(self)
AttributeError: 'OrthoView' object has no attribute 'set_canvas'

[SGaist]

You do realize that your OrthoView does not have such a method ? That its base class (QMainWindow) does not either ?

Therefore since you are taking your code from another project, you might want to check the code of said project for that method.

[mrjj]

@john_hobbyist said in Merge two pieces of code:

set_canvas

But this is not related to the RubberBand thing. ?

if i look in the ORG project
https://github.com/kklmn/OrthoView/blob/master/OrthoView.py

there is no such method?
So did you add it or where does it come from ?

[john_hobbyist]

@SGaist, @mrjj : I have posted the code previously. But again I got the code form github repository and I inserted inside the code for rubberband (all those I have posted in my initial post) I execute the python code and again the same error.... Any ideas??

[mrjj]

@john_hobbyist
Hi
the
'MyMplCanvas' object has no attribute 'rubberBand'
or the
object has no attribute 'set_canvas'

[john_hobbyist]

Hi, sorry, what should I do?

[mrjj]

@john_hobbyist

hi
fix the error.
Tell what line number and what it says.

[john_hobbyist]

@mrjj Hi, for the posted source code above...this is the error:

Traceback (most recent call last):
  File "code.py", line 513, in <module>
    window = OrthoView()
  File "code.py", line 279, in __init__
    self.plotCanvas = MyMplCanvas(self)
  File "code.py", line 113, in __init__
    super().__init__(parent)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5agg.py", line 21, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backends/backend_qt5.py", line 214, in __init__
    super().__init__(figure=figure)
  File "/home/john/Desktop/test/venv/lib/python3.8/site-packages/matplotlib/backend_bases.py", line 1722, in __init__
    figure.set_canvas(self)
AttributeError: 'OrthoView' object has no attribute 'set_canvas'

[mrjj]

Hi

Ok so it has NOTHING to do with the rubberband at all.
Even before you try to insert that, the app was not working.

So it complains about
figure.set_canvas(self)

So perhaps you didnt copy the figure class etc ?

[john_hobbyist]

@mrjj I have copied everything from the github repository. The only small modification I did in rubberband code is that I changed this part:

import sys

from PySide2.QtCore import QRect
from PySide2.QtCore import QSize
from PySide2.QtWidgets import QWidget
from PySide2.QtWidgets import QRubberBand
from PySide2.QtWidgets import QApplication

to this one:

import rubberband
import sys


from PyQt5 import QtWidgets
from PyQt5 import QtCore 


from PyQt5.QtWidgets import * 
from PyQt5 import QtCore, QtGui
from PyQt5.QtGui import * 
from PyQt5.QtCore import * 

Could this be the source of the strange errors?