Skip to content
  • Categories
  • Recent
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Get Qt Extensions
  • Unsolved
Collapse
Brand Logo
  1. Home
  2. Special Interest Groups
  3. Qt Contribution
  4. Gerrit Contributions
Forum Updated to NodeBB v4.3 + New Features

Gerrit Contributions

Scheduled Pinned Locked Moved Qt Contribution
68 Posts 10 Posters 31.9k Views 6 Watching
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • K kkoehne
    17 Jul 2018, 11:26

    @kshegunov said in Gerrit Contributions:

    Also, the forum is not monitored therefore it's going to be even more complicated.

    This would be the biggest problem as I see it. We've been running our own show more or less, Tero being lenient and all. And such "casual" contributions will still need to go through one of QtC's developers (as mentioned in the blog post). It ain't gonna be easy, that's for sure. Also @kkoehne might have something to say for or against here ...

    Let me just say that the legal side has been eased a bit. We can accept patches in forums and bug reports now:

    https://blog.qt.io/blog/2018/05/16/code-contributions-via-bug-reports-forum-posts/

    I'd recommend sticking to bugreports.qt.io for patches though, not setting up anything in particular in forums. Both other users and reviewers are much more likely to find the patch alongside the bug or feature it fixes, in the bug tracker.

    And yes, we should also ease the steps people have to do to contribute via gerrit. I do hope we revisit this soon, after the planned gerrit update...

    A Offline
    A Offline
    aha_1980
    Lifetime Qt Champion
    wrote on 17 Jul 2018, 11:28 last edited by
    #39

    @kkoehne said in Gerrit Contributions:

    after the planned gerrit update...

    Cool. Are there any information about the planned update?

    Qt has to stay free or it will die.

    K 1 Reply Last reply 17 Jul 2018, 11:31
    0
    • A aha_1980
      17 Jul 2018, 11:28

      @kkoehne said in Gerrit Contributions:

      after the planned gerrit update...

      Cool. Are there any information about the planned update?

      K Offline
      K Offline
      kkoehne
      Moderators
      wrote on 17 Jul 2018, 11:31 last edited by
      #40

      @aha_1980 , just that this is very high on the priority list after summer vacation period.

      Director R&D, The Qt Company

      1 Reply Last reply
      2
      • V Offline
        V Offline
        VRonin
        wrote on 30 Jul 2018, 07:28 last edited by
        #41

        Just an idea to facilitate one-off code submission.
        I could prepare a Virtual Box image with a system with all the plumbing in place to contribute to Qt including a small gui to facilitate non pre-configurable actions (like setting up username and password). This should cut down dramatically the time from idea to code.
        Thoughts? If you think it's a bad idea say it, I won't be offended

        "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
        ~Napoleon Bonaparte

        On a crusade to banish setIndexWidget() from the holy land of Qt

        A M 2 Replies Last reply 30 Jul 2018, 07:39
        2
        • V VRonin
          30 Jul 2018, 07:28

          Just an idea to facilitate one-off code submission.
          I could prepare a Virtual Box image with a system with all the plumbing in place to contribute to Qt including a small gui to facilitate non pre-configurable actions (like setting up username and password). This should cut down dramatically the time from idea to code.
          Thoughts? If you think it's a bad idea say it, I won't be offended

          A Offline
          A Offline
          aha_1980
          Lifetime Qt Champion
          wrote on 30 Jul 2018, 07:39 last edited by
          #42

          @VRonin

          That actually sounds great! A Linux system should be save from license side.

          And if the Qt is already configured and build, you'll save the compile time too :)

          Qt has to stay free or it will die.

          1 Reply Last reply
          0
          • V Offline
            V Offline
            VRonin
            wrote on 30 Jul 2018, 08:04 last edited by
            #43

            I was thinking just a straightforward debian build.
            Anyone has a full post-compile qt5.git repo? I just want to know how big the whole package would be.

            "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
            ~Napoleon Bonaparte

            On a crusade to banish setIndexWidget() from the holy land of Qt

            A 1 Reply Last reply 30 Jul 2018, 15:57
            0
            • V VRonin
              30 Jul 2018, 08:04

              I was thinking just a straightforward debian build.
              Anyone has a full post-compile qt5.git repo? I just want to know how big the whole package would be.

              A Offline
              A Offline
              aha_1980
              Lifetime Qt Champion
              wrote on 30 Jul 2018, 15:57 last edited by
              #44

              @VRonin

              I just tried to do a full build, but my system stopped "out of memory" in Qt3D.

              Disk used so far: 23 GB.

              I didn't even include the QtWeb* modules, see below.

              perl init-repository --module-subset=default,-qtwebkit,-qtwebkit-examples,-qtwebengine
              ./configure -developer-build -opensource -nomake examples -nomake tests -confirm-license
              

              Maybe I can get it to fully build tomorrow.

              Qt has to stay free or it will die.

              K 1 Reply Last reply 30 Jul 2018, 20:50
              0
              • V VRonin
                30 Jul 2018, 07:28

                Just an idea to facilitate one-off code submission.
                I could prepare a Virtual Box image with a system with all the plumbing in place to contribute to Qt including a small gui to facilitate non pre-configurable actions (like setting up username and password). This should cut down dramatically the time from idea to code.
                Thoughts? If you think it's a bad idea say it, I won't be offended

                M Offline
                M Offline
                mrjj
                Lifetime Qt Champion
                wrote on 30 Jul 2018, 16:12 last edited by
                #45

                @VRonin
                That would an epic good idea.
                We use this method exclusive at work and sit a huge timer saver.

                1 Reply Last reply
                0
                • S Offline
                  S Offline
                  SGaist
                  Lifetime Qt Champion
                  wrote on 30 Jul 2018, 19:13 last edited by
                  #46

                  What about having it pre-configured and people can start compiling it after they did the modifications they want ?

                  Another possibility could be to provide a docker container ?

                  Interested in AI ? www.idiap.ch
                  Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                  K 1 Reply Last reply 30 Jul 2018, 20:30
                  0
                  • S SGaist
                    30 Jul 2018, 19:13

                    What about having it pre-configured and people can start compiling it after they did the modifications they want ?

                    Another possibility could be to provide a docker container ?

                    K Offline
                    K Offline
                    kshegunov
                    Moderators
                    wrote on 30 Jul 2018, 20:30 last edited by
                    #47

                    Will preconfiguring work, as configure does compile qmake?

                    Read and abide by the Qt Code of Conduct

                    1 Reply Last reply
                    0
                    • S Offline
                      S Offline
                      SGaist
                      Lifetime Qt Champion
                      wrote on 30 Jul 2018, 20:34 last edited by
                      #48

                      Good point, what could be done is to pre-configure Qt, clean everything and just keep the configuration files needed to re-trigger Qt's build.

                      Interested in AI ? www.idiap.ch
                      Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                      1 Reply Last reply
                      0
                      • A aha_1980
                        30 Jul 2018, 15:57

                        @VRonin

                        I just tried to do a full build, but my system stopped "out of memory" in Qt3D.

                        Disk used so far: 23 GB.

                        I didn't even include the QtWeb* modules, see below.

                        perl init-repository --module-subset=default,-qtwebkit,-qtwebkit-examples,-qtwebengine
                        ./configure -developer-build -opensource -nomake examples -nomake tests -confirm-license
                        

                        Maybe I can get it to fully build tomorrow.

                        K Offline
                        K Offline
                        kshegunov
                        Moderators
                        wrote on 30 Jul 2018, 20:50 last edited by kshegunov
                        #49

                        @aha_1980
                        What about building only qtbase or the essential set of modules? That should be more manageable, even if somewhat constraining?
                        Something like the following configuration:

                        $> perl init-repository --module-subset=essential
                        $> ./configure -developer-build -opensource -nomake examples -nomake tests -confirm-license
                        $> make module-qtbase
                        $> make module-qtquickcontrols2
                        $> ... 
                        

                        @SGaist

                        Good point, what could be done is to pre-configure Qt, clean everything and just keep the configuration files needed to re-trigger Qt's build.

                        Ehm, you do need qmake to retrigger the build, or did you mean something else? My concern is with the qmake's paths that are compiled into the binary, maybe patching them would do the trick?

                        Read and abide by the Qt Code of Conduct

                        1 Reply Last reply
                        0
                        • S Offline
                          S Offline
                          SGaist
                          Lifetime Qt Champion
                          wrote on 30 Jul 2018, 20:55 last edited by
                          #50

                          config.status and config.opt are all that are needed.

                          Interested in AI ? www.idiap.ch
                          Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                          K 1 Reply Last reply 30 Jul 2018, 21:32
                          1
                          • S SGaist
                            30 Jul 2018, 20:55

                            config.status and config.opt are all that are needed.

                            K Offline
                            K Offline
                            kshegunov
                            Moderators
                            wrote on 30 Jul 2018, 21:32 last edited by
                            #51

                            Needed for? Triggering configure?

                            Read and abide by the Qt Code of Conduct

                            1 Reply Last reply
                            0
                            • S Offline
                              S Offline
                              SGaist
                              Lifetime Qt Champion
                              wrote on 30 Jul 2018, 21:53 last edited by
                              #52

                              Re-trigger configure using the set of parameter you original passed. In the absolute, config.opt is enough as config.status just calls configure with the -redo option.

                              Interested in AI ? www.idiap.ch
                              Please read the Qt Code of Conduct - https://forum.qt.io/topic/113070/qt-code-of-conduct

                              1 Reply Last reply
                              0
                              • A Offline
                                A Offline
                                aha_1980
                                Lifetime Qt Champion
                                wrote on 31 Jul 2018, 07:01 last edited by aha_1980
                                #53

                                Full build finished with make -j 1 ;)

                                Following sizes include the .git repos, the sources and the developer (debug) build artefacts, as said exluding QtWeb*:

                                961M	./qtxmlpatterns
                                9,0M	./qtspeech
                                58M	./qtgraphicaleffects
                                5,2M	./config.tests
                                2,1M	./coin
                                4,0K	./qtquick1
                                266M	./qtsensors
                                4,0K	./qtdocgallery
                                168M	./qtnetworkauth
                                1,5M	./qtmacextras
                                4,0K	./qtfeedback
                                496M	./qtdatavis3d
                                80M	./qtremoteobjects
                                18M	./qtgamepad
                                1,9G	./qttools
                                41M	./qtimageformats
                                149M	./qtvirtualkeyboard
                                1,6M	./qtandroidextras
                                116M	./qtqa
                                488M	./qtcharts
                                201M	./qtwebview
                                859M	./qtquickcontrols2
                                51M	./qtdoc
                                3,3G	./qt3d
                                4,0K	./qtwebengine
                                2,3G	./qtdeclarative
                                5,9M	./.git
                                1,4M	./qtrepotools
                                12M	./qtserialport
                                27M	./qttranslations
                                1,8G	./qtlocation
                                659M	./qtscript
                                174M	./qtwebsockets
                                160M	./qtquickcontrols
                                13M	./qtwayland
                                904M	./qtmultimedia
                                7,9G	./qtbase
                                70M	./qtscxml
                                202M	./qtserialbus
                                4,7M	./qtwinextras
                                4,7M	./gnuwin32
                                441M	./qtconnectivity
                                125M	./qtcanvas3d
                                21M	./qtwebglplugin
                                162M	./qtwebchannel
                                151M	./qtpurchasing
                                254M	./qtsvg
                                3,8M	./qtx11extras
                                4,0K	./qtpim
                                4,0K	./qtenginio
                                4,4M	./qtactiveqt
                                4,0K	./qtsystems
                                25G	.
                                

                                Qt has to stay free or it will die.

                                V 1 Reply Last reply 31 Jul 2018, 07:10
                                0
                                • A aha_1980
                                  31 Jul 2018, 07:01

                                  Full build finished with make -j 1 ;)

                                  Following sizes include the .git repos, the sources and the developer (debug) build artefacts, as said exluding QtWeb*:

                                  961M	./qtxmlpatterns
                                  9,0M	./qtspeech
                                  58M	./qtgraphicaleffects
                                  5,2M	./config.tests
                                  2,1M	./coin
                                  4,0K	./qtquick1
                                  266M	./qtsensors
                                  4,0K	./qtdocgallery
                                  168M	./qtnetworkauth
                                  1,5M	./qtmacextras
                                  4,0K	./qtfeedback
                                  496M	./qtdatavis3d
                                  80M	./qtremoteobjects
                                  18M	./qtgamepad
                                  1,9G	./qttools
                                  41M	./qtimageformats
                                  149M	./qtvirtualkeyboard
                                  1,6M	./qtandroidextras
                                  116M	./qtqa
                                  488M	./qtcharts
                                  201M	./qtwebview
                                  859M	./qtquickcontrols2
                                  51M	./qtdoc
                                  3,3G	./qt3d
                                  4,0K	./qtwebengine
                                  2,3G	./qtdeclarative
                                  5,9M	./.git
                                  1,4M	./qtrepotools
                                  12M	./qtserialport
                                  27M	./qttranslations
                                  1,8G	./qtlocation
                                  659M	./qtscript
                                  174M	./qtwebsockets
                                  160M	./qtquickcontrols
                                  13M	./qtwayland
                                  904M	./qtmultimedia
                                  7,9G	./qtbase
                                  70M	./qtscxml
                                  202M	./qtserialbus
                                  4,7M	./qtwinextras
                                  4,7M	./gnuwin32
                                  441M	./qtconnectivity
                                  125M	./qtcanvas3d
                                  21M	./qtwebglplugin
                                  162M	./qtwebchannel
                                  151M	./qtpurchasing
                                  254M	./qtsvg
                                  3,8M	./qtx11extras
                                  4,0K	./qtpim
                                  4,0K	./qtenginio
                                  4,4M	./qtactiveqt
                                  4,0K	./qtsystems
                                  25G	.
                                  
                                  V Offline
                                  V Offline
                                  VRonin
                                  wrote on 31 Jul 2018, 07:10 last edited by
                                  #54

                                  @aha_1980 Thanks!

                                  @SGaist and @kshegunov My idea was to pre-configure and even make. That's really the time saving part. The rest can literally be included in a bash file, it's not really that taxing.

                                  @SGaist said in Gerrit Contributions:

                                  provide a docker container

                                  That's actually another great idea

                                  "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                                  ~Napoleon Bonaparte

                                  On a crusade to banish setIndexWidget() from the holy land of Qt

                                  1 Reply Last reply
                                  0
                                  • A Offline
                                    A Offline
                                    aha_1980
                                    Lifetime Qt Champion
                                    wrote on 31 Jul 2018, 07:26 last edited by
                                    #55

                                    As someone that has not used Docker before: it is not as cross-platform as VirtualBox, i.e. you can use a Linux docker only in a Linux environment, not Windows, right?

                                    Qt has to stay free or it will die.

                                    1 Reply Last reply
                                    2
                                    • M Offline
                                      M Offline
                                      mrjj
                                      Lifetime Qt Champion
                                      wrote on 31 Jul 2018, 09:32 last edited by
                                      #56

                                      Hi
                                      Dockers can be used in windows too but no gui possible as far as i know.
                                      So VM would be so much more flexible and cross platform.
                                      also dockers requires user to learn how to use them ( new commands, integration etc)
                                      where as WM is still just a normal linux.

                                      1 Reply Last reply
                                      0
                                      • V Offline
                                        V Offline
                                        VRonin
                                        wrote on 31 Jul 2018, 09:40 last edited by
                                        #57

                                        Ok, so:

                                        • VM over docker

                                        Open issues

                                        • "pre-config & make" or "pre-config and delete unnecessary stuff"
                                        • where would it be appropriate to host such a big file?
                                        • how often should it be updated and what would be the best way to do it?

                                        "La mort n'est rien, mais vivre vaincu et sans gloire, c'est mourir tous les jours"
                                        ~Napoleon Bonaparte

                                        On a crusade to banish setIndexWidget() from the holy land of Qt

                                        A K 2 Replies Last reply 31 Jul 2018, 09:54
                                        0
                                        • V VRonin
                                          31 Jul 2018, 09:40

                                          Ok, so:

                                          • VM over docker

                                          Open issues

                                          • "pre-config & make" or "pre-config and delete unnecessary stuff"
                                          • where would it be appropriate to host such a big file?
                                          • how often should it be updated and what would be the best way to do it?
                                          A Offline
                                          A Offline
                                          aha_1980
                                          Lifetime Qt Champion
                                          wrote on 31 Jul 2018, 09:54 last edited by
                                          #58

                                          @VRonin said in Gerrit Contributions:

                                          where would it be appropriate to host such a big file?

                                          Don't forget the traffic that is generated when downloading...

                                          For me and my limited networks speed, even downloading such a big file takes several hours.

                                          how often should it be updated and what would be the best way to do it?

                                          Another good one :) For now, I'd set it to the tip of qt5 5.11 branch, so you could do fixes easily and even push something to dev/5.12 with good chance it can be cherry-picked without conflict.

                                          That would mean you'd have to renew it in approx. half a year, when 5.12 is out (Given that the average user downloads no beta releases anyway).

                                          Qt has to stay free or it will die.

                                          1 Reply Last reply
                                          0

                                          • Login

                                          • Login or register to search.
                                          • First post
                                            Last post
                                          0
                                          • Categories
                                          • Recent
                                          • Tags
                                          • Popular
                                          • Users
                                          • Groups
                                          • Search
                                          • Get Qt Extensions
                                          • Unsolved