Gerrit Contributions

kshegunov

@kshegunov said in Gerrit Contributions:

@SGaist said in Gerrit Contributions:

Threads on the forum tends to disappear over time and the patches would be really hard to associate with any given bug/problem.

This can be fixed by introducing a couple of special rules, so I don't see it as a big problem.

Any example in mind ?

A set of rules how would a drive-by contribution look like and what information it should contain. That'd include the link and ticket number, formatted code - with tags and appropriate code style and perhaps a requirement for a test case. I agree that it'd be better to do this in JIRA, simply as it allows also code to be uploaded directly, not just pasted inside the text as here. Still I do agree that a person should be assigned to at least monitor the hypothetical subforum and to make sure posts there are compliant.

My concern is rather that there will be unexperienced people finding these patches (I know it goes against my suggestion that threads get lost in times), apply them and possibly trigger new bugs that will make their life way harder than it should be.

You mean directly? That's crazy! ;)
Joke aside a big fat disclaimer should deal with that problem - the code is experimental and for Qt's own use, do not apply in your code base - or something along those lines.

Tero trusted us because we proved our worthiness.

You may have, but I did no such thing! ;P

I have some ideas about that but I don't know yet about the implementation.

You should open a thread and lay it out for us, maybe an idea will sprout out of it.

however you can make all these settings local to your Qt repositories.

This is what I do. Global configs are evil.

kkoehne

@kshegunov said in Gerrit Contributions:

Also, the forum is not monitored therefore it's going to be even more complicated.

This would be the biggest problem as I see it. We've been running our own show more or less, Tero being lenient and all. And such "casual" contributions will still need to go through one of QtC's developers (as mentioned in the blog post). It ain't gonna be easy, that's for sure. Also @kkoehne might have something to say for or against here ...

Let me just say that the legal side has been eased a bit. We can accept patches in forums and bug reports now:

https://blog.qt.io/blog/2018/05/16/code-contributions-via-bug-reports-forum-posts/

I'd recommend sticking to bugreports.qt.io for patches though, not setting up anything in particular in forums. Both other users and reviewers are much more likely to find the patch alongside the bug or feature it fixes, in the bug tracker.

And yes, we should also ease the steps people have to do to contribute via gerrit. I do hope we revisit this soon, after the planned gerrit update...

aha_1980

@kkoehne said in Gerrit Contributions:

after the planned gerrit update...

Cool. Are there any information about the planned update?

kkoehne

@aha_1980 , just that this is very high on the priority list after summer vacation period.

VRonin

Just an idea to facilitate one-off code submission.
I could prepare a Virtual Box image with a system with all the plumbing in place to contribute to Qt including a small gui to facilitate non pre-configurable actions (like setting up username and password). This should cut down dramatically the time from idea to code.
Thoughts? If you think it's a bad idea say it, I won't be offended

aha_1980

@VRonin

That actually sounds great! A Linux system should be save from license side.

And if the Qt is already configured and build, you'll save the compile time too :)

VRonin

I was thinking just a straightforward debian build.
Anyone has a full post-compile qt5.git repo? I just want to know how big the whole package would be.

aha_1980

@VRonin

I just tried to do a full build, but my system stopped "out of memory" in Qt3D.

Disk used so far: 23 GB.

I didn't even include the QtWeb* modules, see below.

perl init-repository --module-subset=default,-qtwebkit,-qtwebkit-examples,-qtwebengine
./configure -developer-build -opensource -nomake examples -nomake tests -confirm-license

Maybe I can get it to fully build tomorrow.

mrjj

@VRonin
That would an epic good idea.
We use this method exclusive at work and sit a huge timer saver.

SGaist

What about having it pre-configured and people can start compiling it after they did the modifications they want ?

Another possibility could be to provide a docker container ?

kshegunov

Will preconfiguring work, as configure does compile qmake?

SGaist

Good point, what could be done is to pre-configure Qt, clean everything and just keep the configuration files needed to re-trigger Qt's build.

kshegunov

@aha_1980
What about building only qtbase or the essential set of modules? That should be more manageable, even if somewhat constraining?
Something like the following configuration:

$> perl init-repository --module-subset=essential
$> ./configure -developer-build -opensource -nomake examples -nomake tests -confirm-license
$> make module-qtbase
$> make module-qtquickcontrols2
$> ...

@SGaist

Good point, what could be done is to pre-configure Qt, clean everything and just keep the configuration files needed to re-trigger Qt's build.

Ehm, you do need qmake to retrigger the build, or did you mean something else? My concern is with the qmake's paths that are compiled into the binary, maybe patching them would do the trick?

SGaist

config.status and config.opt are all that are needed.

kshegunov

Needed for? Triggering configure?

SGaist

Re-trigger configure using the set of parameter you original passed. In the absolute, config.opt is enough as config.status just calls configure with the -redo option.

aha_1980

Full build finished with make -j 1 ;)

Following sizes include the .git repos, the sources and the developer (debug) build artefacts, as said exluding QtWeb*:

961M	./qtxmlpatterns
9,0M	./qtspeech
58M	./qtgraphicaleffects
5,2M	./config.tests
2,1M	./coin
4,0K	./qtquick1
266M	./qtsensors
4,0K	./qtdocgallery
168M	./qtnetworkauth
1,5M	./qtmacextras
4,0K	./qtfeedback
496M	./qtdatavis3d
80M	./qtremoteobjects
18M	./qtgamepad
1,9G	./qttools
41M	./qtimageformats
149M	./qtvirtualkeyboard
1,6M	./qtandroidextras
116M	./qtqa
488M	./qtcharts
201M	./qtwebview
859M	./qtquickcontrols2
51M	./qtdoc
3,3G	./qt3d
4,0K	./qtwebengine
2,3G	./qtdeclarative
5,9M	./.git
1,4M	./qtrepotools
12M	./qtserialport
27M	./qttranslations
1,8G	./qtlocation
659M	./qtscript
174M	./qtwebsockets
160M	./qtquickcontrols
13M	./qtwayland
904M	./qtmultimedia
7,9G	./qtbase
70M	./qtscxml
202M	./qtserialbus
4,7M	./qtwinextras
4,7M	./gnuwin32
441M	./qtconnectivity
125M	./qtcanvas3d
21M	./qtwebglplugin
162M	./qtwebchannel
151M	./qtpurchasing
254M	./qtsvg
3,8M	./qtx11extras
4,0K	./qtpim
4,0K	./qtenginio
4,4M	./qtactiveqt
4,0K	./qtsystems
25G	.

VRonin

@aha_1980 Thanks!

@SGaist and @kshegunov My idea was to pre-configure and even make. That's really the time saving part. The rest can literally be included in a bash file, it's not really that taxing.

@SGaist said in Gerrit Contributions:

provide a docker container

That's actually another great idea

aha_1980

As someone that has not used Docker before: it is not as cross-platform as VirtualBox, i.e. you can use a Linux docker only in a Linux environment, not Windows, right?

mrjj

Hi
Dockers can be used in windows too but no gui possible as far as i know.
So VM would be so much more flexible and cross platform.
also dockers requires user to learn how to use them ( new commands, integration etc)
where as WM is still just a normal linux.