Support for QStandardItem proxies?
-
@elfring said in Support for QStandardItem proxies?:
How do you think about the introduction of a class like QProxyModelIndex then?
QAbstractPorxyModel::mapToSource/QAbstractPorxyModel::mapFromSourcealready do everything that class would do so I see no gain in introducing itShould the difference between indexes for proxy and source models be better described in the Qt documentation?
A proxy model is still a model, the docs say "Note that it's undefined behavior to pass illegal indices to item models" so I feel it is documented already
wrote on 5 Oct 2018, 13:01 last edited byA proxy model is still a model,
This information is generally appropriate.
the docs say "Note that it's undefined behavior to pass illegal indices to item models"
A constraint is mentioned.
so I feel it is documented already
Now I imagine that a better class design can prevent the passing of inappropriate indexes a bit more.
How are the chances to specify that QAbstractProxyModel-like objects need to work with QProxyModelIndex objects instead? -
A proxy model is still a model,
This information is generally appropriate.
the docs say "Note that it's undefined behavior to pass illegal indices to item models"
A constraint is mentioned.
so I feel it is documented already
Now I imagine that a better class design can prevent the passing of inappropriate indexes a bit more.
How are the chances to specify that QAbstractProxyModel-like objects need to work with QProxyModelIndex objects instead?wrote on 5 Oct 2018, 13:06 last edited by VRonin 10 May 2018, 13:06@elfring said in Support for QStandardItem proxies?:
Now I imagine that a better class design can prevent the passing of inappropriate indexes a bit more.
Agree that's why I said:
I'm surprised it didn't just assert.
How are the chances to specify that QAbstractProxyModel-like objects need to work with QProxyModelIndex objects instead?
QAbstractProxyModelis a subclass ofQAbstractItemModeland the view should not care whether the model it's attached to is a proxy or not
-
@elfring said in Support for QStandardItem proxies?:
Now I imagine that a better class design can prevent the passing of inappropriate indexes a bit more.
Agree that's why I said:
I'm surprised it didn't just assert.
How are the chances to specify that QAbstractProxyModel-like objects need to work with QProxyModelIndex objects instead?
QAbstractProxyModelis a subclass ofQAbstractItemModeland the view should not care whether the model it's attached to is a proxy or not
wrote on 5 Oct 2018, 13:15 last edited bythe view should not care whether the model it's attached to is a proxy or not
Can overloaded functions (from a specific proxy class) help any more to detect questionable indexes?
-
the view should not care whether the model it's attached to is a proxy or not
Can overloaded functions (from a specific proxy class) help any more to detect questionable indexes?
wrote on 5 Oct 2018, 14:12 last edited by@elfring said in Support for QStandardItem proxies?:
Can overloaded functions (from a specific proxy class) help any more to detect questionable indexes?
It can help but there's no bullet proof solution.
In the meantime I submitted a change to QStandardItemModel that would have made your bug assert in debug
-
@elfring said in Support for QStandardItem proxies?:
Can overloaded functions (from a specific proxy class) help any more to detect questionable indexes?
It can help but there's no bullet proof solution.
In the meantime I submitted a change to QStandardItemModel that would have made your bug assert in debug
wrote on 5 Oct 2018, 14:23 last edited byIn the meantime I submitted a change to QStandardItemModel that would have made your bug assert in debug
I find it interesting that my clarification request triggered such a software evolution finally.
Would you like to continue the development discussion also around proxies for QStandardItem (or eventually other classes)? -
@elfring said in Support for QStandardItem proxies?:
Can overloaded functions (from a specific proxy class) help any more to detect questionable indexes?
It can help but there's no bullet proof solution.
In the meantime I submitted a change to QStandardItemModel that would have made your bug assert in debug
@VRonin said in Support for QStandardItem proxies?:
assert in debug
But only when Qt was compiled in debug mode which is for sure not the case...
-
@VRonin said in Support for QStandardItem proxies?:
assert in debug
But only when Qt was compiled in debug mode which is for sure not the case...
wrote on 5 Oct 2018, 15:24 last edited by@Christian-Ehrlicher said in Support for QStandardItem proxies?:
But only when Qt was compiled in debug mode
Yes, as the docs say using invalid indexes remains undefined behaviour, I am just trying to help users spot these cases
21/27