Save QImage from BYTE buffer segfaults ?
-
@mranger90 said in Save QImage from BYTE buffer segfaults ?:
try:
BYTE *buf = new BYTE[imWidth * imHeight];Hi, it is not crashing anymore, however the image seems to be coming out completely black. I will confirm tomorrow if the image is supposed to be completely black or not...
-
From the documentation
https://doc.qt.io/qt-5/qimage.html#QImage-4
data must be32-bit aligned, and each scanline of data in the image must also be32-bit aligned.So (as far as I understand) that is not enough to have memory buffer aligned to 32 bit address, also each line have to be aligned to 32 bit address. So if you have image that is 260x300 pixels, a whole line will take 288 bytes. So for whole image you should have 288*300 bytes which is more than you have provided.
-
@Jarek-B said in Save QImage from BYTE buffer segfaults ?:
From the documentation
https://doc.qt.io/qt-5/qimage.html#QImage-4
data must be32-bit aligned, and each scanline of data in the image must also be32-bit aligned.So (as far as I understand) that is not enough to have memory buffer aligned to 32 bit address, also each line have to be aligned to 32 bit address. So if you have image that is 260x300 pixels, a whole line will take 288 bytes. So for whole image you should have 288*300 bytes which is more than you have provided.
Hi, interesting...I have not seen any examples like that. How are you arriving at 288 bytes ? Are you suggesting I make the buffer 288x300 bytes instead ?
-
@R-P-H Of course it's black, the data never gets initialized.
Also, the reason why it doesn't crash is because:
BYTE *buf = new BYTE(x * y); // allocates a single byte, initialized to the value of (x * y)
BYTE *buf = new BYTE[x * y]; // allocates an array of bytes whose size is x * y -
@mranger90 said in Save QImage from BYTE buffer segfaults ?:
@R-P-H Of course it's black, the data never gets initialized.
Also, the reason why it doesn't crash is because:
BYTE *buf = new BYTE(x * y); // allocates a single byte, initialized to the value of (x * y)
BYTE *buf = new BYTE[x * y]; // allocates an array of bytes whose size is x * yI don't quite understand what you're saying to be honest. Where are you saying the issue is ?
-
@R-P-H here is the amended code
// allocates a buffer of imWidth * imHeight bytes, which depending on the compiler // settings will either be initialized to zero, or may contain garbage BYTE *buf = new BYTE[imWidth * imHeight]; // creates a QImage based on the data in the buffer, QImage img(buf, imWidth, imHeight, QImage::Format_Grayscale8); // saves the data img.save("image.bmp", "BMP"); delete [] buf;The point is that you never put actual image data into the buffer.
-
@mranger90 said in Save QImage from BYTE buffer segfaults ?:
@R-P-H here is the amended code
// allocates a buffer of imWidth * imHeight bytes, which depending on the compiler // settings will either be initialized to zero, or may contain garbage BYTE *buf = new BYTE[imWidth * imHeight]; // creates a QImage based on the data in the buffer, QImage img(buf, imWidth, imHeight, QImage::Format_Grayscale8); // saves the data img.save("image.bmp", "BMP"); delete [] buf;The point is that you never put actual image data into the buffer.
This is already what I did according to your first post. The buffer IS populated, I just didn't show that API call. I will modify my original post to make this clear...
So the result is a completely black image. This may be normal but I will have to check with the API provider.
EDIT: I have edited my original post.
-
Is that some private library you can't share ? Or would it be possible to have more information about that API ?
-
@SGaist said in Save QImage from BYTE buffer segfaults ?:
Is that some private library you can't share ? Or would it be possible to have more information about that API ?
Your assumption is correct. There really aren't any additional details on using this API function. It simply takes as input a reference to the buffer and a unique id of the capturing device. It then populates the buffer in place. The example in the documentation initializes the buffer the same way as shown in my original post.
If we are sure the error is on the API side, then they will need to fix that.
I made the assumption that the error was in saving the image to disk.
-
Then are you sure their BYTE type is not something custom ? Do they also show how to access the data ?
Is it the Windows BYTE type ?
-
-
@SGaist said in Save QImage from BYTE buffer segfaults ?:
Then are you sure their BYTE type is not something custom ? Do they also show how to access the data ?
Is it the Windows BYTE type ?
They do not show how to access the data afterwards.
It's defined as
typedef unsigned char BYTE;fromwindows.h. -
@mranger90 said in Save QImage from BYTE buffer segfaults ?:
@R-P-H Of course it's black, the data never gets initialized.
Also, the reason why it doesn't crash is because:
BYTE *buf = new BYTE(x * y); // allocates a single byte, initialized to the value of (x * y)
BYTE *buf = new BYTE[x * y]; // allocates an array of bytes whose size is x * yThe image is always black and it's not supposed to be, so this doesn't work.
-
Hi, you could try explicitly specify the number of bytes per line:
Edit: also, it could be that your deleting the buffer before the QImage is deleted:BYTE *buf = new BYTE(imWidth * imHeight); //Populate buf with data using API call here (not shown) { QImage img(buf, imWidth, imHeight, imWidth, QImage::Format_Grayscale8); img.save("image.bmp", "BMP"); } delete [] buf; -
@hskoglund said in Save QImage from BYTE buffer segfaults ?:
Hi, you could try explicitly specify the number of bytes per line:
Edit: also, it could be that your deleting the buffer before the QImage is deleted:BYTE *buf = new BYTE(imWidth * imHeight); //Populate buf with data using API call here (not shown) { QImage img(buf, imWidth, imHeight, imWidth, QImage::Format_Grayscale8); img.save("image.bmp", "BMP"); } delete [] buf;Hi, thanks for the suggestion. I tried it and result is the same...still crashes on occasion.
I also tried with removing the
delete [] bufline and still the same. -
@R-P-H
If yourBYTEmeansunsigned char, then the expression ofnew BYTE(imWidth * imHeight)is definitely wrong.
As @mranger90 says, that really means you allocate a buf of only one byte size, whose value is (imWidth * imHeight).
So I won't be surprised that it crashes. -
@Bonnie said in Save QImage from BYTE buffer segfaults ?:
@R-P-H
If yourBYTEmeansunsigned char, then the expression ofnew BYTE(imWidth * imHeight)is definitely wrong.
As @mranger90 says, that really means you allocate a buf of only one byte size, whose value is (imWidth * imHeight).
So I won't be surprised that it crashes.I tried with
new BYTE[imWidth * imHeight]as well but the image is always black. -
@R-P-H
Right, this is another problem.
How can you be sure your populated data is not all black?
I will suggest you do some tests without Qt classes.BYTE *buf = new BYTE[imWidth * imHeight]; //Populate buf with data using API call here (not shown) bool AllZero = true; for(int i = 0; i < imWidth * imHeight; i++) { if(buf[i] != 0) AllZero = false; } qDebug() << "AllZero :" << AllZero; delete [] buf;Or you can just print all of the data to see whether it is all zero(black).
