A few design questions...
-
I'm still trying to learn the terminology here. By "change signals," are you referring to the "emit" statements?
On a side note, I notice that, in order to display one member, I've needed to add three routines to my Soc class: a get, a set and a getString. If I wanted to display, say, a dozen variables at once, that could make for a rather large source file. Do you have any tips on organizing files for this kind of application?
-
[quote author="mzimmers" date="1302197505"]I'm still trying to learn the terminology here. By "change signals," are you referring to the "emit" statements?[/quote]
I was not making myself clear. It should have been notify signals, not change signals. And you need to emit them, obviously.[quote]On a side note, I notice that, in order to display one member, I've needed to add three routines to my Soc class: a get, a set and a getString. If I wanted to display, say, a dozen variables at once, that could make for a rather large source file. Do you have any tips on organizing files for this kind of application?[/quote]
You don't always need a string version. If you need such a thing often, you can choose another method than adding a string property. Using javascript is one option, or create another simple conversino object, or... For every problem, there are multiple solutions.On the number of methods you need for properties: true, but they can almost all be one-liners, and from QtCreator 2.2 you can have Creator implement them for you :-)
-
[quote]I was not making myself clear. It should have been notify signals, not change signals. And you need to emit them, obviously. [/quote]
I'm still not sure I know what you're referring to. Isn't the notify signal the one called from the set routine? And, as such, it's generated automatically (I don't write it), right? Or are you talking about something else?
-
[quote author="mzimmers" date="1302199414"][quote]I was not making myself clear. It should have been notify signals, not change signals. And you need to emit them, obviously. [/quote]
I'm still not sure I know what you're referring to. Isn't the notify signal the one called from the set routine? And, as such, it's generated automatically (I don't write it), right? Or are you talking about something else?[/quote]
No, that automatic generation only goes for properties you define in QML, not for properties on QObjects. Those must have notify signals defined (and emitted, of course) for the properties you want to use from QML.
-
Aargh...I'm sorry to be so dense, but I'm not connecting the dots here. This is what I know I've done to effect a QML display for a single member:
used the Q_PROPERTY macro in the .h file for the class
created a get and a set for this member
declared a (member-name)Changed signal for the class...but did NOT define it
put an emit in for this signal in a couple places in the code
Plus, of course, all the QML formatting.
So...what am I missing here?
-
Oh, right...I guess that should go on the list, too. Thanks, Andre.
I think I'm done with this thread. I've got some new questions, but they're more appropriate for a new thread.
Once again, thanks to everyone who helped out an old dog trying to learn new tricks.
-
Sorry for the delay in answering, I've been out of the office and in meetings a lot.
@mzimmers, wrt changing the QML document it is up to you how you do it. I tend to use the text editor rather than the design mode. I have not had a chance to play with the qml design mode recently so it has probably changed a great deal since I tsarted looking at qml.
If you find yourself reusing the same pattern over and over in a qml scene then you may want to read up on factoring out the commonality into a custom qml Component. This is akin to having a class in C++.
-
Hey, Zap...if you're still getting alerts on this thread:
I'm trying to move the Qt logic we implemented in this thread from one class (Soc) to another (Filter).
I commented out most of the Qt code in the Soc class, but I'm getting a build error that a particular routine isn't declared in the scope of the SoC class. The problem is, it's coming from the moc_Soc.cpp file. Is this enough information for you to tell me what I might have missed?
Thanks.
-
Here's the error message:
bq. moc_Soc.cpp: In member function 'virtual int Soc::qt_metacall(QMetaObject::Call, int, void**)':
moc_Soc.cpp:98: error: 'shaperOutIString' was not declared in this scope
moc_Soc.cpp:104: error: 'setShaperOutI' was not declared in this scopeHere's the code snippet from the moc_Soc file:
@#ifndef QT_NO_PROPERTIES
else if (_c == QMetaObject::ReadProperty) {
void *_v = _a[0];
switch (_id) {
case 0: reinterpret_cast< long>(_v) = getShaperOutI(); break;
case 1: reinterpret_cast< QString>(_v) = shaperOutIString(); break;
}
@(It's complaining about the case 1 line.)
Header files: I'm trying to keep this post brief, but here's the header for the filter class:
@class DemodShaperFilter : public QObject
{
Q_OBJECT
Q_PROPERTY (long shaperOutI
READ getShaperOutI WRITE setShaperOutI NOTIFY shaperOutIChanged)
Q_PROPERTY (QString shaperOutIString
READ shaperOutIString NOTIFY shaperOutIStringChanged)
private:
vector<Cell> cellArrayI;
vector<Cell> cellArrayQ;
long shaperOutI; // for Qt display purposes
public:
DemodShaperFilter(QObject *parent = 0,
long rv = 0); // constructor w/ reset param
DemodShaperFilter(QObject *parent = 0,
const DemodShaperFilter &dsf = 0); // copy constructor
~DemodShaperFilter(); // destructor
void cycle(long combGainI,
long *shaperCoeffI,
long combGainQ,
long *shaperCoeffQ,
bool clockEnable,
bool resetState);
// void testCycle();
void reset();
long getCoeffs(long *aI, long *aQ);
void display();
void setFilterClockEnable(bool n);
long getDemShpIOut();
long getDemShpQOut();
long getShaperOutI() ;
void setShaperOutI(long i);
QString shaperOutIString();public slots:
void testCycle();signals:
void shaperOutIChanged ();
void shaperOutIStringChanged ();
};@Let me know what else you might need. Thanks...
-
It looks as if you still have the Q_PROPERTY() declaration in your soc.h file but that you have already removed all of the other related functionality - the setter, getter and notifier signal. Is that correct?
Make sure you rhave no Q_PROPERTY() stuff left in the soc.h file.
-
Good eye. I removed them, and got rid of that error. Now, I'm getting:
@Undefined symbols:
"vtable for DemodShaperFilter", referenced from:
__ZTV17DemodShaperFilter$non_lazy_ptr in DemodShaperFilter.o
(maybe you meant: __ZTV17DemodShaperFilter$non_lazy_ptr)
"DemodShaperFilter::shaperOutIChanged()", referenced from:
DemodShaperFilter::setShaperOutI(long) in DemodShaperFilter.o
@This is because I didn't change my connect commands in the widget, isn't it? Now, I have to think about this...the filter object isn't visible to the widget.
-
That type of error often occurs when you forget to:
- include the Q_OBJECT macro (which I see you have) or
- forget to add the header file to the HEADERS section of the .pro file or
- forget to re-run qmake after doing so.
Look in your build dir and see if you have a moc_demodshaperfilter.cpp being generated as part of the build process.
-
The header file is in the .pro file.
I'm pretty sure qmake is run automatically as part of my build.
And no, the mod_demodshaperfilter.cpp file isn't there.
But, I think my problem is a bit more fundamental, isn't it? When we configured this originally, we set it up so that the Soc class was the "interface" to the UI. Now, though, I want to move the UI logic into the filter class, but...I don't create a new instance of the filter in widget like I do the Soc.
I'd like the Soc class to still contain the filter (and other) class, but I'd prefer to move the UI part of the exercise closer to the actual data. The element we chose for this demonstration is part of the filter class, not the Soc.
-
No, the lack of moc_demodshaperfiler.cpp is the entire problem here (well the linker unresolved symbols error anyway). Can you post your .pro file please and try doing
@
make distclean
qmake -r
make
@and post the output of the qmake and make steps please.
With respect to exposing your DemodShaperFilter object and it's properties, that is simple. Just provide a function on your Soc class that returns a pointer to the contained DemodShaperFilter. Once you have the pointer available to your widget or qml scene then you can proceed just like we did before.
-
OK, here's the .pro file:
@######################################################################
Automatically generated by qmake (2.01a) Mon Mar 28 17:09:16 2011
######################################################################
TEMPLATE = app
TARGET =
DEPENDPATH += . headers src
INCLUDEPATH += . headersAPP_QML_FILES.files = DemodShaperFilter.qml
APP_QML_FILES.path = Contents/MacOS
QMAKE_BUNDLE_DATA += APP_QML_FILESQT += core gui declarative
Input
HEADERS +=
headers/clock.h
headers/DemodShaperFilter.h
headers/globals.h
headers/register_offsets.h
headers/Soc.h
headers/SocReg.h
headers/widget.h
headers/GenericCell.h
headers/DemodCicTuner.h
headers/SystolicFilter.h
headers/modpredist.h
headers/Nco.h
headers/nyquist.h
headers/nyquistcell.h
headers/modshaperfilter.h
headers/modciccomb.h
headers/modciccombstage.h
headers/socreg64.h
SOURCES +=
src/clock.cpp
src/DemodShaperFilter.cpp
src/filestuff.cpp
src/globals.cpp
src/main.cpp
src/Soc.cpp
src/SocReg.cpp
src/widget.cpp
src/GenericCell.cpp
src/DemodCicTuner.cpp
src/SystolicFilter.cpp
src/modpredist.cpp
src/nco.cpp
src/nyquist.cpp
src/nyquistcell.cpp
src/modshaperfilter.cpp
src/modciccomb.cpp
src/modciccombstage.cpp
src/socreg64.cppFORMS +=
widget.uiOTHER_FILES +=
DemodShaperFilter.qmlRESOURCES +=
simple.qrc
@Those commands you posted are from the shell, right? I got this error on the make command:
bq. make: *** No rule to make target `distclean'. Stop.
-
OK, I did it from Creator. "Run qmake" returned this:
@Running build steps for project simulatorGUI...
Starting: "/usr/bin/qmake" /Users/mzimmers/wideband/SoC simulator/simulatorGUI/simulatorGUI.pro -r -spec macx-g++ QMLJSDEBUGGER_PATH=/Developer/Applications/Qt/Qt Creator.app/Contents/Resources/qml/qmljsdebugger
The process "/usr/bin/qmake" exited normally.@And the build returned a whole bunch of stuff that I won't bother putting here (unless you really want it), but it did build successfully this time. And I checked the build directory, and I now have files for the filter there.
Now, in the UI, the value displays as "undefined." And, I'm getting a couple run-time errors about "no such signal." One is on this line (in soc.cpp):
@ connect (this, SIGNAL(shaperOutIChanged()), this, SIGNAL(shaperOutIStringChanged()));
@And the other is (in widget.cpp):
@ connect (soc, SIGNAL(shaperOutIChanged()), this, SLOT(updateShaperOutI()));
@ -
OK. For some reason then the build system had not noticed that qmake needed to be re-run. But at least it is fixed now.
For the signals...
The first connect statement should now be moved into the DemodShaperFilter class since that is where we have all of the Qt property stuff now.
The second statement should be changed to something like this:
@
connect (soc->demodShaperFilter(), SIGNAL(shaperOutIChanged()), this, SLOT(updateShaperOutI()));
@where you need to add:
@
DemodShaperFilter* demodShaperFilter() const { return m_demodShaperFilter; }
@to your Soc class. Note that I have used "m_demodShaperFilter" but I have not seen your Soc.h header file so you'll have to replace that with whatever you called your pointer to the DemodShaperFilter object.
That should remove those runtime warnings.
Incidentally, I find it useful to run with the environment variable QT_FATAL_WARNINGS=1 set. With that in place any runtiem warnings form Qt will cause your app to abort at that point which the debugger will catch so that you can inspect the stack trace. You can set the above in the Qt-Creator project settings under the RunTime Configuration tab.
