Maybe im to dumb, but i cant get the icons to work.

Joe von Habsburg

You have iconThemes folder.
In the iconThemes you have NothingTheme folder.
NothingTheme folder has icons.

there is ok.

iconThemes can be has ABCTheme folder.
and ABCTheme folder has same icons but different styles.

If I understand true. You want to like that ?

now You say :
1 - I want to change theme. when theme change icon change.
2 - User can add own icon theme folder.

Solution for Question 1 :

add icon to xxx.qrc file

void MainWindow::on_comboBox_currentTextChanged(QString text)
{
    ui->spotify->setIcon(QIcon(QPixmap(QString(":/iconThemes/%1/spotify.png").arg(text)));
    ...
}

That must be work.

Solution for Question 2 :

you need list in iconThemes folder folders. and add to combox on start. also custom themes folder have to have icons with same name.

NOTE :
You may need to copy the “themefolder” folder to the “exe” folder. This way, you can access the file directory without using QRC. It will be easier for you.

MSC615

This post is deleted!

Joe von Habsburg

@Joe-von-Habsburg said in Maybe im to dumb, but i cant get the icons to work.:

You may need to copy the “themefolder” folder to the “exe” folder. This way, you can access the file directory without using QRC. It will be easier for you.

follow that way.

for : resouces file add
Right Click your project -> add new file -> qt -> qt resources file

MSC615

@Joe-von-Habsburg ok, got it, qrc file is in. Now i did add prefix and typed / as prefix, should i also type something in the Lang thing and alias?

Joe von Habsburg

There's no need; I think you can leave it as “/” in the prefix section because you're creating subfolders within the folder.

To reiterate, you may need to copy it into the EXE folder, or create a folder in another location—such as the Documents folder—and place it there. I’m mentioning this because users can add their own themes. This is because the resources file is compiled along with your application.

Joe von Habsburg

I think you generally understand what you need to do. Create a folder in a location accessible to the user, check that location when the app launches, and add the themes to the combo box or another location to apply the changes.

The QRC file is necessary for this reason. If the theme folder is missing, the default theme stored there will be used. So it’s not entirely unnecessary.

MSC615

@Joe-von-Habsburg ok, that means if people want to add their own themes, they need to edit the qrc file? or can i do like i tried to that the code recognizes new folders in the icon themes folder and uses the icons in there?(and holy frick, i need to do a lot to make it easy for others to use it. i also need to make it compatible to my Raspberry Pi 4B with frickin 1GB RAM and 3GB swap. thats gonna be a journey!

Joe von Habsburg

@MSC615 said in Maybe im to dumb, but i cant get the icons to work.:

hey need to edit the qrc file

no because qrc file compiler with when your build. my opinion qrc file have to hold defult themes only. users can not change it.

For users :
you have to folder somewhere (documents or exe folder etc.)
that folder has your default themes and user custom themes.

you read path and add to combobox

MSC615

@Joe-von-Habsburg ok but how do i do the displaying of custom ones than? because how should i implement them that i dont have the same problem that caused this thread to be created but with custom themes?

SGaist

@MSC615 because you will get the absolute path to the folder containing the theme from you user.
And if something is missing, you can use the image of the default theme to not break anything and tell the user through a message that something is wrong.

MSC615

@SGaist true, thanks. but now i dont know how to turn the code that @Joe-von-Habsburg gave me, this code:

void MainWindow::on_comboBox_currentTextChanged(QString text)
{
    ui->spotify->setIcon(QIcon(QPixmap(QString(":/iconThemes/%1/spotify.png").arg(text)));
    ...
}

into a working version for my code, because i already have a thing to show the name of the theme and choose it:

    // some logic to set the theme
    connect(ui->themeComboBox, &QComboBox::currentTextChanged,
            this, [=](const QString &theme) {
        setTheme(theme);
    });

oh my god i need to learn C++ in the future!!

SGaist

I suspect that your setTheme function is where you update all the icons, right ?
So it's there that you should use the example path creation.

MSC615

@SGaist oooohh right. oversaw the %1 in the path. yeee gonna put something there for the user warning when i got the other things done!